Reduce number of passes through spatialized_chunk_predictions + update metadata field name #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylmak
approved these changes
Jul 25, 2024
cloud_functions/climateiq_spatialize_chunk_predictions_cf/main.py
Outdated
Show resolved
Hide resolved
waltaskew
approved these changes
Jul 25, 2024
| @@ -289,7 +289,7 @@ def _build_spatialized_model_predictions( | |||
| ) | |||
|
|
|||
|
|
|||
| def _add_h3_index_details(cell: pd.Series) -> pd.Series: | |||
| def _add_h3_index_details(cell: pd.Series, chunk_boundary: Any) -> pd.Series: | |||
There was a problem hiding this comment.
this probably isn't actually an Any ?
you can do
print(chunk_boundary.__class__)
if you aren't sure what the right type is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.